Skip to content

Add HPKE (RFC 9180) C# wrapper#10171

Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:hpke_csharp
Apr 13, 2026
Merged

Add HPKE (RFC 9180) C# wrapper#10171
SparkiDev merged 1 commit intowolfSSL:masterfrom
dgarske:hpke_csharp

Conversation

@dgarske
Copy link
Copy Markdown
Contributor

@dgarske dgarske commented Apr 8, 2026

Description

Add HPKE (RFC 9180) C# wrapper and tests

Testing

Done with CSharp tests

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Apr 8, 2026
Copilot AI review requested due to automatic review settings April 8, 2026 21:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a C# P/Invoke wrapper for HPKE (RFC 9180) plus a console-style test that exercises Base mode seal/open and public-key serialization round-trip.

Changes:

  • Added HPKE native imports and managed helper APIs (init, keygen, serialize/deserialize, seal/open, free).
  • Added HPKE Base mode test flow to the C# test runner.
  • Enabled HAVE_HPKE in the C# wrapper user settings.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Adds HPKE P/Invoke bindings and managed convenience APIs for base-mode single-shot operations
wrapper/CSharp/wolfCrypt-Test/wolfCrypt-Test.cs Adds an HPKE base-mode functional test (keygen, serialize/deserialize, seal/open)
wrapper/CSharp/user_settings.h Enables HPKE in the C# wrapper build configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Comment thread wrapper/CSharp/user_settings.h
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Comment thread wrapper/CSharp/wolfCrypt-Test/wolfCrypt-Test.cs
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs Outdated
Copilot AI review requested due to automatic review settings April 12, 2026 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Comment thread wrapper/CSharp/wolfSSL_CSharp/wolfCrypt.cs
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10171

No scan targets match the changed files in this PR. Review skipped.

@SparkiDev SparkiDev merged commit 9176185 into wolfSSL:master Apr 13, 2026
392 of 395 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants