Add documentation for new OCSP responder and cert accessor APIs#10147
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Apr 9, 2026
Merged
Add documentation for new OCSP responder and cert accessor APIs#10147dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds/extends Doxygen documentation for newly introduced OCSP responder/request/response APIs and decoded-certificate accessor helpers.
Changes:
- Documented OCSP request/response allocation, initialization, and encoding APIs in
ocsp.h. - Added Doxygen docs for OCSP responder creation, signer registration, status configuration, and response/error response generation.
- Added Doxygen docs for decoded certificate subject/issuer/serial accessor APIs in
asn_public.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| doc/dox_comments/header_files/ocsp.h | Adds public API documentation for OCSP request/response helpers and OCSP responder APIs. |
| doc/dox_comments/header_files/asn_public.h | Adds public API documentation for decoded certificate subject/issuer/serial accessors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
retest this please |
dgarske
approved these changes
Apr 9, 2026
dgarske
approved these changes
Apr 9, 2026
Member
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 1 total — 1 posted, 0 skipped
Posted findings
- [Medium] Missing \code example blocks in asn_public.h entries —
doc/dox_comments/header_files/asn_public.h:3375-3470
Review generated by Skoll via openclaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.