Conversation
gregor
approved these changes
May 15, 2017
lipis
approved these changes
May 15, 2017
gregor
pushed a commit
that referenced
this pull request
May 15, 2017
sidneys
added a commit
to sidneys/wire-desktop
that referenced
this pull request
May 18, 2017
* master: New native module rebuilding (wireapp#643) Publish amplify events when joining calls (wireapp#629) Use new V8 inspector (wireapp#641) electron 1.6.9 (wireapp#637) Release 2.14.2743 Add template for github issues Update libsodium-neon to 2.1.0 (wireapp#634) Update electron-build-env to 0.2.0 (wireapp#633)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Electron 1.7.0 the app could not be started anymore, because
--debugwas removed from Node.js (see electron/electron#9434 and nodejs/node#12197).This commit fixes the startup error and adds the V8 inspector.