Making the merchant ID required to render a button

Jeff Harrell · Jeff Harrell · commit d5943a228b2c · 2012-10-19T17:12:26.000-07:00
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ Buy Now buttons are for single item purchases.
 
 ```html
 <script src="paypal.js?merchant=MERCHANT_ID"
-    data-type="buy"
+    data-type="buynow"
     data-item_name="Buy me now!"
     data-amount="1.00"
 ></script>
diff --git a/paypal.js b/paypal.js
@@ -40,13 +40,21 @@ PAYPAL.apps = PAYPAL.apps || {};
 		 * @param el {HTMLElement} The element to replace
 		 * @param type (String) The type of the button to render
 		 * @param data {Object} An object of key/value data to set as button params
+		 * @return {Boolean}
 		 */
 		app.renderButton = function (el, type, data) {
 			var merchantId = el.src.split('?merchant=')[1],
 				form = document.createElement('form'),
 				btn = document.createElement('input'),
 				hidden = document.createElement('input'),
-				btn, hidden, input, key;
+				input, key;
+
+			// Don't render if there's no merchant ID
+			if (merchantId) {
+				data.business = merchantId;
+			} else {
+				return false;
+			}
 
 			btn.type = 'image';
 			hidden.type = 'hidden';
@@ -69,10 +77,6 @@ PAYPAL.apps = PAYPAL.apps || {};
 				btn.src = BUY_BTN_URL;
 			}
 
-			if (merchantId) {
-				data.business = merchantId
-			}
-
 			for (key in data) {
 				input = hidden.cloneNode(true);
 				input.name = key;
@@ -92,6 +96,8 @@ PAYPAL.apps = PAYPAL.apps || {};
 					PAYPAL.apps.MiniCart.render();
 				}, 'PAYPAL.apps.MiniCart');
 			}
+
+			return true;
 		};
 
 		/**
