Fix for issue #1. This now works in IE 7/8/9

Jeff Harrell · Jeff Harrell · commit 29f5a40b4cfb · 2012-10-19T17:07:31.000-07:00
diff --git a/index.html b/index.html
@@ -129,13 +129,13 @@ <h3 id="buy-now">Buy Now</h3>
 <p>Buy Now buttons are for single item purchases.</p>
 
 <pre><code>&lt;script src="paypal.js?merchant=6XF3MPZBZV6HU"
-    data-type="buy"
+    data-type="buynow"
     data-item_name="Buy me now!"
     data-amount="1.00"
 &gt;&lt;/script&gt;</code></pre>
 
 <script src="paypal.js?merchant=6XF3MPZBZV6HU"
-    data-button="buy"
+    data-button="buynow"
     data-item_name="Buy me now!"
     data-amount="1.00"
 ></script>
diff --git a/paypal.js b/paypal.js
@@ -10,18 +10,18 @@ PAYPAL.apps = PAYPAL.apps || {};
 	'use strict';
 
 
-	var PAYPAL_URL = 'https://www.paypal.com/cgi-bin/webscr',
-		CART_BTN_URL = '//www.paypalobjects.com/en_US/i/btn/btn_cart_LG.gif',
-		BUY_BTN_URL = '//www.paypalobjects.com/en_US/i/btn/btn_buynow_LG.gif',
-		MINICART_URL = 'http://www.minicartjs.com/build/minicart.js';
-
-
 	// Don't execute the code multiple times!
 	if (PAYPAL.apps.DynamicButton) {
 		return;
 	}
 
 
+	var PAYPAL_URL = 'https://www.paypal.com/cgi-bin/webscr',
+		CART_BTN_URL = '//www.paypalobjects.com/en_US/i/btn/btn_cart_LG.gif',
+		BUY_BTN_URL = '//www.paypalobjects.com/en_US/i/btn/btn_buynow_LG.gif',
+		MINICART_URL = 'http://www.minicartjs.com/build/minicart.js';
+
+
 	PAYPAL.apps.DynamicButton = (function () {
 		var app = {};
 
@@ -48,11 +48,11 @@ PAYPAL.apps = PAYPAL.apps || {};
 				hidden = document.createElement('input'),
 				btn, hidden, input, key;
 
+			btn.type = 'image';
+			hidden.type = 'hidden';
 			form.method = 'post';
 			form.action = PAYPAL_URL;
 			form.appendChild(btn);
-			hidden.type = 'hidden';
-			btn.type = 'image';
 
 			// Cart buttons
 			if (type === 'cart') {
@@ -103,9 +103,10 @@ PAYPAL.apps = PAYPAL.apps || {};
 
 			for (i = 0, len = nodes.length; i < len; i++) {
 				node = nodes[i];
-				data = node.dataset;
+				data = getDataSet(node);
+				button = data && data.button;
 
-				if ((button = data.button)) {
+				if (button) {
 					this.renderButton(node, button, data);
 				}
 			}
@@ -134,6 +135,34 @@ PAYPAL.apps = PAYPAL.apps || {};
 	}
 
 
+	/**
+	 * Utility function to polyfill dataset functionality for browsers
+	 *
+	 * @param el {HTMLElement} The element to check
+	 * @return {Object}
+	 */
+	function getDataSet(el) {
+		var dataset = el.dataset,
+			attrs, attr, matches, len, i;
+
+		if (!dataset) {
+			dataset = {};
+
+			if ((attrs = el.attributes)) {
+				for (i = 0, len = attrs.length; i < len; i++) {
+					attr = attrs[i];
+
+					if ((matches = /^data-(.+)/.exec(attr.name))) {
+						dataset[matches[1]] = attr.value;
+					}
+				}
+			}
+		}
+
+		return dataset;
+	}
+
+
 	PAYPAL.apps.DynamicButton.init();
 
 }());
