Skip to content

use the mark tag #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Haroenv wants to merge 1 commit into from
Closed

use the mark tag #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use the mark tag 
it's more semantic 😄

it adds a default background colour, but we'll use the one you defined.

https://developer.mozilla.org/en/docs/Web/HTML/Element/mark
  • Loading branch information
@Haroenv
Haroenv committed Dec 9, 2016
commit 85089794d8ac19c1208dccd69e63c3f22dabc84b
4 changes: 2 additions & 2 deletions 06 - Type Ahead/index-FINISHED.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
const matchArray = findMatches(this.value, cities);
const html = matchArray.map(place => {
const regex = new RegExp(this.value, 'gi');
const cityName = place.city.replace(regex, `<span class="hl">${this.value}</span>`);
const stateName = place.state.replace(regex, `<span class="hl">${this.value}</span>`);
const cityName = place.city.replace(regex, `<mark>${this.value}</mark>`);
const stateName = place.state.replace(regex, `<mark>${this.value}</mark>`);
return `
<li>
<span class="name">${cityName}, ${stateName}</span>
Expand Down
2 changes: 1 addition & 1 deletion 06 - Type Ahead/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
font-size: 15px;
}

.hl {
mark {
background:#ffc600;
}

Expand Down