Skip to content

JS Drum Kit #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hypatiah wants to merge 5 commits into from
Closed

JS Drum Kit #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2107e3
Console.log keyCodes pressed
hypatiah Dec 9, 2016
5fd7d94
Get audio to play for corresp keyCode
hypatiah Dec 9, 2016
56771ad
Play keystroke audio in quick succession
hypatiah Dec 9, 2016
cae2897
Add and remove playing class when key pressed with transition
hypatiah Dec 9, 2016
7842712
Modularize playSound function
hypatiah Dec 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add and remove playing class when key pressed with transition
  • Loading branch information
@hypatiah
hypatiah committed Dec 9, 2016
commit cae28972f8659f86c7871878d61289aa663a77d2
15 changes: 13 additions & 2 deletions 01 - JavaScript Drum Kit/index-START.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,24 @@
<script>
window.addEventListener('keydown', function(e) {
const audio = document.querySelector(`audio[data-key="${e.keyCode}"]`);
console.log(audio)
const key = document.querySelector(`.key[data-key="${e.keyCode}"]`);
if(!audio) return; //stop function all together
// note if call .play on audio element already playing, it won't play again. so if press "F" in successsion it will only play every 5 sec
audio.currentTime = 0; //rewind to the start, so that it can be played many times quickly
audio.play();

// CSS: transition:all .07s;
//.playing adds transform:scale(1.1);
key.classList.add('playing');
});

function removeTransition(e) {
if (e.propertyName !== 'transform') return; // skip it if its not a transform
// here this = key div
this.classList.remove('playing');
}

const keys = document.querySelectorAll('.key');
keys.forEach(key => key.addEventListener('transitionend', removeTransition));
</script>


Expand Down
2 changes: 1 addition & 1 deletion 01 - JavaScript Drum Kit/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ body,html {
margin:1rem;
font-size: 1.5rem;
padding:1rem .5rem;
transition:all .07s;
transition:all .1s;
width:100px;
text-align: center;
color:white;
Expand Down