Skip to content

Release 1.12.1 - #3660

Merged
wenzhixin merged 10 commits into
masterfrom
develop
Mar 12, 2018
Merged

wenzhixin merged 10 commits into
masterfrom
develop

Conversation

@wenzhixin

Copy link
Copy Markdown
Owner

No description provided.

danielsharvey and others added 9 commits March 6, 2018 07:34
the collision is faced when group-by-v2 plugin is used along w/ enabled detailView — if one expands one or more rows in a group into detailView mode & then clicks on tr.groupBy row to collapse this group, the source rows become hidden just as expected, but their detailView representations still stay visible & expanded

applied patch fixes the issue
the rigorous testing [on patch fiddle](#3598 (comment)) revealed the prefix `.bootstrap-table .table > tbody > tr.groupBy +` which has been initially applied just to follow the existing style is redundant &,  moreover, for this concrete case is harmful 'cause it brings the mess on selectors & leads to the fault of the whole patch scheme after all

as you can see https://jsfiddle.net/juliyvchirkov/jdwLp29e unprefixed rule achieves the goal as initially planned
Doco fix: Minor correction describing onCheckSome
@ghost ghost assigned wenzhixin Mar 12, 2018
@ghost ghost added the In progress PRs that are working in progress. label Mar 12, 2018
@wenzhixin
wenzhixin merged commit 71a1a5a into master Mar 12, 2018
@ghost ghost removed the In progress PRs that are working in progress. label Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants