fix: Members dialog stale workspace data#5710
Merged
Merged
Conversation
Track which workspace the cached listMembers response belongs to. Only expose that data when the tracked workspaceId matches the current workspace; otherwise return undefined so the list shows 'Loading…' instead of members from the previously-viewed workspace. Extract selectMembersData as a pure function and add unit tests.
Instead of tracking which workspace the cached data belongs to inside
the component, add key={workspace.id} on ManageMembersDialog in both
parent usages. When the workspace changes React remounts the component,
resetting all internal state (including the useQuery data) so stale
member data from the previous workspace can never appear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.