Merged
Conversation
montogeek
approved these changes
May 10, 2018
alexander-akait
approved these changes
May 10, 2018
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
reviewed
May 11, 2018
| "lodash": "^4.17.4", | ||
| "prettier": "^1.11.1", | ||
| "pug": "^2.0.3", | ||
| "pug-loader": "^2.4.0", |
Member
There was a problem hiding this comment.
Could you remove the jade-loader from dependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
yes
If relevant, link to documentation update:
N/A
Summary
jadeis deprecated in favor ofpug.Moreover there are multiple security advisories for
jadedependencies.Note: I did not completely removed
jadebecause it is used withinbrowsertest(which I plan to clean in another PR).Does this PR introduce a breaking change?
no