chore(pkg): update typescript nightly to Version 2.9.0-dev.20180421#7091
Merged
chore(pkg): update typescript nightly to Version 2.9.0-dev.20180421#7091
Conversation
Member
Author
|
Updating TS Version now to dev.20180421 which should have these errors resolved. For a variety of issues this PR fixes, I'm hoping to land this (if CI doesn't fail, I'll reference issues it solves for us blocking other type support) |
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Apr 22, 2018
Member
|
Thanks, also to the typescript team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update dependencies
Did you add tests for your changes?
N/A
If relevant, link to documentation update:
N/A
Summary
This PR updates the TypeScript nightly dependency for blocking
import("./module")support for commonJS module and class types.The updated version would be
2.9.0-dev.20180421Does this PR introduce a breaking change?
No, this is only for the build step, however this was failing locally. I will use this PR as a way to report this failure upstream (so lets wait on actually merging this).
Other information
microsoft/TypeScript#23588 Upstream issue I've submitted for when this PR fails.