Conversation
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
montogeek
approved these changes
Mar 22, 2018
sokra
approved these changes
Mar 22, 2018
TheLarkInn
approved these changes
Mar 23, 2018
Jessidhia
reviewed
Mar 23, 2018
sokra
requested changes
Mar 24, 2018
Member
There was a problem hiding this comment.
I changed my mind on this one (thanks @Kovensky for pointing this out).
The difference between Reflect and Object.defineProperty is that Object.defineProperty throws if the operation fails. (Reflect.defineProperty returns false)
So what's the behavior we want here? In my opinion we want an error to be thrown if the property can't be defined. An error here indicates that something is wrong here. We don't want this to be silently ignored...
Contributor
|
@ooflorent Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
sokra
approved these changes
Mar 26, 2018
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
no
If relevant, link to documentation update:
n/a
Summary
Reflect.definePropertyis more meaningful thanObject.defineProperty. InternallyReflect.dPperforms less checks thanObject.dP.Use
Object.definePropertyDoes this PR introduce a breaking change?
no