Skip to content

bot: Fix Markdown format for output logs#6756

Merged
sokra merged 1 commit intowebpack:masterfrom
montogeek:fix/bot-logs-output-format
Mar 14, 2018
Merged

bot: Fix Markdown format for output logs#6756
sokra merged 1 commit intowebpack:masterfrom
montogeek:fix/bot-logs-output-format

Conversation

@montogeek
Copy link
Copy Markdown
Member

@montogeek montogeek commented Mar 14, 2018

What kind of change does this PR introduce?

Fix for bug introduce in #6713

Did you add tests for your changes?

No, but tested that this formatting actually works in montogeek/webpack-dev-middleware-bug#1 (comment)

Summary

It looks like Markdown code formatting inside <details> tag needs an empty line above it to correctly format code.

Before this change
image

After this change
image

image

Does this PR introduce a breaking change?
No

@montogeek montogeek changed the title bot: Fix markdown format bot: Fix Markdown format for output logs Mar 14, 2018
@sokra sokra merged commit 2194acf into webpack:master Mar 14, 2018
@sokra
Copy link
Copy Markdown
Member

sokra commented Mar 14, 2018

Thanks

@montogeek montogeek deleted the fix/bot-logs-output-format branch March 14, 2018 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants