Add node-independent shim for global setImmediate()#663
Merged
Conversation
clearImmediate has no own option as it is directly connected with setImmediate
Member
Author
|
It's failing on node 0.11 because of a missing sandbox... |
Member
Author
|
Can now be merged. |
Member
There was a problem hiding this comment.
Does it make sense to have node.setImmediate and node.clearImmediate?
Member
Author
There was a problem hiding this comment.
I was wondering about that too, butsetImmediate and clearImmediate are imho closely linked together. You wouldn't want to specify individual options for that. If there's a setImmediate it needs a clearImmediate as well. And since you always think of setImmediate and barely need clearImmediate I decided to call it setImmediate.
sokra
added a commit
that referenced
this pull request
Jan 10, 2015
Add node-independent shim for global setImmediate()
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #419
Btw: Why is the console shim deactivated by default?