Fixed Parser so that this Expression can work with ProvidePlugin#6588
Merged
sokra merged 1 commit intowebpack:masterfrom Feb 27, 2018
Merged
Fixed Parser so that this Expression can work with ProvidePlugin#6588sokra merged 1 commit intowebpack:masterfrom
sokra merged 1 commit intowebpack:masterfrom
Conversation
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Feb 27, 2018
Member
|
Thanks |
Contributor
Author
|
@sokra, i was having some doubts regarding this however, could you please answer #6526 (comment) . Thanks 😃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
BugFix
Did you add tests for your changes?
Yes
If relevant, link to documentation update:
N/A
Summary
Fixes #6526
Does this PR introduce a breaking change?
No
Other information
Now this expression have free property according to whether they are top level or not.