Conversation
move JS and WASM specific template stuff into plugins
ooflorent
reviewed
Jan 24, 2018
| const dependencyTemplates = options.dependencyTemplates; | ||
|
|
||
| for(const module of chunk.modulesIterable) { | ||
| if(module.type && module.type.startsWith("webassembly")) { |
Contributor
There was a problem hiding this comment.
I always thought module.type couldn't be unset.
Member
Author
There was a problem hiding this comment.
hmm.. yes, I only moved the code. When this code was written I considered unset module.type for backward-compatibility.
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
existing tests
If relevant, link to documentation update:
N/A
Summary
make render manifest extensible
move JS and WASM specific template stuff into plugins
Does this PR introduce a breaking change?
no
Other information
This will be useful for adding custom module types or the extract-text-webpack-plugin
cc @michael-ciniawsky