Addition of documentation for CONTRIBUTING.md/Discussions#6199
Addition of documentation for CONTRIBUTING.md/Discussions#6199sokra merged 1 commit intowebpack:masterfrom MagicPoulp:issue-6163-update-contributing-doc-for-long-discussions
Conversation
|
Thierry Vilmart seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
left a comment
There was a problem hiding this comment.
Fix your git configuration to use a GitHub accepted email
|
I am curious to know: Why is it bad to have a fake email in the commit @fake.email.org? |
|
We need to be able to assign an owner to each commit/LOC for legal reasons. The owner need to sign the CLA, so we can publish the code with the MIT license. If you want to hide your email address, please use the way provided by github: https://help.github.com/articles/about-commit-email-addresses/ |
|
@MagicPoulp Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
|
I fixed the email issue. And I used a valid github email. Sorry I did not know I had a noreply github email. |
|
Thanks |
What kind of change does this PR introduce?
HERE:
added doc
see the end of
#6163
Did you add tests for your changes?
not needed for doc
If relevant, link to documentation update:
Summary
added doc
see the end of
#6163
Does this PR introduce a breaking change?
Other information