Conversation
| return str; | ||
| }; | ||
|
|
||
| const getArray = set => Array.from(set); |
There was a problem hiding this comment.
move to lib/util/toArray.js && getArray =>toArray ?
There was a problem hiding this comment.
I don't think a separate module make sense for a single line of code. This increases code size, decreases performance and readablility.
There was a problem hiding this comment.
Yeah, it isn't really needed here, especially after the last refactor :)
| return 0; | ||
| }; | ||
|
|
||
| const getFrozenArray = set => Object.freeze(Array.from(this)); |
There was a problem hiding this comment.
move to lib/util/toFrozenArray.js && getFrozenArray =>toFrozenArray ?
| return 0; | ||
| }; | ||
|
|
||
| const getFrozenArray = set => Object.freeze(Array.from(this)); |
There was a problem hiding this comment.
move to lib/util/toFrozenArray.js && getFrozenArray => toFrozenArray ?
| return str; | ||
| }; | ||
|
|
||
| const getArray = set => Array.from(set); |
There was a problem hiding this comment.
move to lib/util/toArray.js && getArray => toArray ?
| */ | ||
| getChunks() { | ||
| return Array.from(this._chunks); | ||
| return this._chunks.getCachedInfo(getArray); |
| return a.debugId - b.debugId; | ||
| }; | ||
|
|
||
| const getFrozenArray = set => Object.freeze(Array.from(this)); |
There was a problem hiding this comment.
use lib/util/toFrozenArray.js ? :)
| str += m.identifier() + "#"; | ||
| }); | ||
| return str; | ||
| return this._modules.getOrderIndependentCachedInfo(getModulesIdent); |
There was a problem hiding this comment.
getOrderIndependentCache(d)
OrderIndenpendent => Unordered/Unsorted/Orderless
|
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @michael-ciniawsky Please review the new changes. |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
What kind of change does this PR introduce?
refactor caching
Did you add tests for your changes?
existing tests
If relevant, link to documentation update:
N/A
Summary
more caching -> performance
Does this PR introduce a breaking change?
yes
Other information