Also add script.crossOrigin for hot-reloaded chunks#5729
Merged
sokra merged 1 commit intowebpack:masterfrom Sep 30, 2017
Merged
Also add script.crossOrigin for hot-reloaded chunks#5729sokra merged 1 commit intowebpack:masterfrom
sokra merged 1 commit intowebpack:masterfrom
Conversation
Related: webpack#988 Useful especially for hot-reloaded React 16 apps so that the global onerror handler can render error boundaries properly.
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
approved these changes
Sep 30, 2017
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix - or a feature, depending on your point of view.
Did you add tests for your changes?
I didn't see any tests asserting this behavior; however, I ran the change on my own applications and found that it fixed the React 16 errors we were seeing (https://facebook.github.io/react/docs/cross-origin-errors.html)
Summary
Also adds the
crossOriginattribute to hot-reloaded chunks ifoutput.crossOriginLoadingis set.Related: #988
Useful especially for hot-reloaded React 16 apps so that the global
onerror handler can render error boundaries properly.
Does this PR introduce a breaking change?
No breaking change - dev only.