Skip to content

Use SortableSets for Chunk.parents/blocks#5709

Merged
sokra merged 2 commits intonextfrom
refactor/sets
Sep 22, 2017
Merged

Use SortableSets for Chunk.parents/blocks#5709
sokra merged 2 commits intonextfrom
refactor/sets

Conversation

@sokra
Copy link
Copy Markdown
Member

@sokra sokra commented Sep 22, 2017

What kind of change does this PR introduce?
refactor to Sets

Did you add tests for your changes?
existing tests

If relevant, link to documentation update:
N/A

Summary

Does this PR introduce a breaking change?
yes

Other information

@webpack-bot
Copy link
Copy Markdown
Contributor

@sokra The tests look fine, but there are code style issue in your Pull Request. Please review the following:

> webpack@3.5.6 travis:lint /home/travis/build/webpack/webpack
> npm run lint-files && npm run nsp


> webpack@3.5.6 lint-files /home/travis/build/webpack/webpack
> npm run lint && npm run beautify-lint


> webpack@3.5.6 lint /home/travis/build/webpack/webpack
> eslint lib bin hot buildin "test/**/webpack.config.js" "test/binCases/**/test.js" "examples/**/webpack.config.js"


> webpack@3.5.6 beautify-lint /home/travis/build/webpack/webpack
> beautify-lint "lib/**/*.js" "hot/**/*.js" "bin/**/*.js" "benchmark/*.js" "test/*.js"

Fine. (334 files checked)

> webpack@3.5.6 nsp /home/travis/build/webpack/webpack
> nsp check --output summary

(+) 1 vulnerabilities found
 Name           Installed   Patched   Path                                                                                                                            More Info                              
 tough-cookie   2.3.3       None      webpack@3.5.6 > watchpack@1.4.0 > chokidar@1.7.0 > fsevents@1.1.2 > node-pre-gyp@0.6.38 > request@2.81.0 > tough-cookie@2.3.3   https://nodesecurity.io/advisories/525 

See complete report here.

@sokra sokra merged commit 1c2835a into next Sep 22, 2017
@sokra sokra deleted the refactor/sets branch September 22, 2017 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants