Allow scope hoisting to process modules in multiple chunks#5064
Merged
Allow scope hoisting to process modules in multiple chunks#5064
Conversation
ecd78c5 to
5d4ba56
Compare
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
jdalton
reviewed
Jun 22, 2017
| relevantModules.push(module); | ||
| // Module must not be the entry points | ||
| if(module.getChunks().some(chunk => chunk.entryModule === module)) { | ||
| setBailoutReason(module, "ModuleConcatenation (inner)", "module is an entrypoint"); |
Contributor
There was a problem hiding this comment.
"ModuleConcatenation (inner)", "module is an entrypoint"
What does this mean? Can it be avoided?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
yes
If relevant, link to documentation update:
N/A
Summary
Allow scope hoisting to process modules in multiple chunks
Does this PR introduce a breaking change?
no
Other information