ES6 refactor of NodeSourcePlugin#4831
Merged
sokra merged 2 commits intowebpack:masterfrom May 7, 2017
Merged
Conversation
|
|
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
sokra
requested changes
May 6, 2017
Member
sokra
left a comment
There was a problem hiding this comment.
Use const instead of let when possible
Contributor
|
@Orlandster98 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
sokra
approved these changes
May 6, 2017
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ES6 Refactor
Did you add tests for your changes?
No
If relevant, link to documentation update:
N/A
Summary
The Refactoring makes the code more consistent to the ES6 standards. issue #4099
Does this PR introduce a breaking change?
No
Other information
It's my first Contribution to Webpack. Maybe this little fun hack helps other people to find es5 code https://github.com/Orlandster98/es5-finder
You can just change the path or es5 and es6 keywords in the code.