Merged
Conversation
|
|
sokra
approved these changes
Mar 2, 2017
Member
|
Thanks |
Contributor
Author
|
@sokra if this kind of merge requests are welcome here, I'll keep working on this refactoring stuff, 5to6. I think I can create merge requests for each 3-5 files refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
I didn't add new test cases. All existing tests are passed.
If relevant, link to documentation update:
N/A
Summary
In shortly, consistent code base. I've updated variable declarations according to ES6. Related issue is #4099.
Does this PR introduce a breaking change?
It doesn't introduce any breaking change.
Other information
I've worked on these files;
lib/AmdMainTemplatePlugin.js
lib/BasicEvaluatedExpression.js
lib/Chunk.js
lib/Compilation.js