Skip to content

Allow to supress uglifyjs warnings#4200

Merged
sokra merged 4 commits into
webpack:masterfrom
timse:allow-to-supress-uglifyjs-warnings
Feb 9, 2017
Merged

Allow to supress uglifyjs warnings#4200
sokra merged 4 commits into
webpack:masterfrom
timse:allow-to-supress-uglifyjs-warnings

Conversation

@timse
Copy link
Copy Markdown
Contributor

@timse timse commented Feb 4, 2017

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

yes

If relevant, link to documentation update:

N/A

Summary

fixes #1496 by adding a warningsFilter function to options for the UglifyJsPlugin that decides which warnings should be shown

Does this PR introduce a breaking change?

No

Other information

The test setup for uglifyJs is a bit messy so i just hacked in two tests. I didnt feel like making sense out of it.

Copy link
Copy Markdown
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an integration test. -> configCases

@sokra sokra merged commit be4f27c into webpack:master Feb 9, 2017
@sokra
Copy link
Copy Markdown
Member

sokra commented Feb 9, 2017

Thanks, please also update the documenation.

@timse timse deleted the allow-to-supress-uglifyjs-warnings branch February 25, 2017 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Squelch uglify warnings for node_modules

2 participants