Add tests for ModuleDependencyError#3982
Merged
TheLarkInn merged 1 commit intowebpack:masterfrom Jan 21, 2017
Merged
Conversation
11 tasks
874f9a6 to
bc95173
Compare
sokra
requested changes
Jan 18, 2017
| }); | ||
|
|
||
| it("has a details property", function() { | ||
| env.moduleDependencyError.details.should.containEql("test/ModuleDependencyError.test.js:"); |
Contributor
Author
There was a problem hiding this comment.
@sokra Good catch, thanks! Will use path to generate
bc95173 to
1199171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add tests for ModuleDependencyError
Did you add tests for your changes?
This PR is only tests
If relevant, link to documentation update:
N/A
Summary
Based on the coveralls report, the
ModuleDependencyErrorfile has 20% test coverage. There is noModuleDependencyErrorspecific test file - this is added in this PR and aims to achieve 100% test coverage.https://coveralls.io/builds/9689291/source?filename=lib%2FModuleDependencyError.js
Does this PR introduce a breaking change?
No
Other information
None