Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add tests for CachePlugin
Did you add tests for your changes?
This PR is only tests
If relevant, link to documentation update:
N/A
Summary
Based on the coveralls report, the
CachePluginfile has 84% test coverage. There is noCachePluginspecific test file - this is added in this PR and aims to achieve 100% test coverage.https://coveralls.io/builds/9567491/source?filename=lib%2FCachePlugin.js
Does this PR introduce a breaking change?
No
Other information
The coverage of this file appears to depend on whether it is called in other tests (in other builds it has a coverage of 86%) - https://coveralls.io/builds/9568583/source?filename=lib%2FCachePlugin.js
The
applyPluginWithOptionshelper function has been update to expose the plugin and plugin environment if a custom context is provided. This is a backwards compatible change.