Skip to content

Refactor EntryOptionPlugin to ES2015 class#3799

Merged
TheLarkInn merged 1 commit intowebpack:masterfrom
jackfranklin:refactor-entry-options-plugin
Jan 6, 2017
Merged

Refactor EntryOptionPlugin to ES2015 class#3799
TheLarkInn merged 1 commit intowebpack:masterfrom
jackfranklin:refactor-entry-options-plugin

Conversation

@jackfranklin
Copy link
Copy Markdown
Contributor

What kind of change does this PR introduce?

Refactors EntryOptionPlugin to ES2015

Did you add tests for your changes?

No - but no new functionality.

If relevant, link to documentation update:

Summary

Help the ES2015 migration efforts and record a video on contributing to Webpack :)

Does this PR introduce a breaking change?

Other information

@jsf-clabot
Copy link
Copy Markdown

jsf-clabot commented Jan 5, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!!!

@TheLarkInn
Copy link
Copy Markdown
Member

Awesome this looks good pending CI!! Thank you so much for submitting your first PR!!!!!!

@TheLarkInn
Copy link
Copy Markdown
Member

🍾

@TheLarkInn TheLarkInn merged commit b5a6684 into webpack:master Jan 6, 2017
@jackfranklin
Copy link
Copy Markdown
Contributor Author

🎉

@jackfranklin jackfranklin deleted the refactor-entry-options-plugin branch January 6, 2017 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants