refactor(ES6): upgraded FlagIncludedChunksPlugin to ES6#3752
Merged
TheLarkInn merged 1 commit intowebpack:masterfrom Jan 4, 2017
shubheksha:refactor-FlagIncludedChunksPlugin
Merged
refactor(ES6): upgraded FlagIncludedChunksPlugin to ES6#3752TheLarkInn merged 1 commit intowebpack:masterfrom shubheksha:refactor-FlagIncludedChunksPlugin
TheLarkInn merged 1 commit intowebpack:masterfrom
shubheksha:refactor-FlagIncludedChunksPlugin
Conversation
liujingbreak
reviewed
Feb 6, 2017
| if(chunkA === chunkB) return; | ||
| // is chunkB in chunkA? | ||
| if(chunkA.modules.length < chunkB.modules.length) return; | ||
| for(var i = 0; i < chunkB.modules.length; i++) { |
There was a problem hiding this comment.
It seems to be simpler to use lodash
const _ = require('lodash');
...
if (_.difference(chunkB.modules, chunkA.modules).length === 0)
chunkA.ids.push(chunkB.id);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor, ES5 => ES6
Did you add tests for your changes?
All existing tests pass
If relevant, link to documentation update:
N/A
Summary
Upgrade the FlagIncludedChunksPlugin to ES6
Does this PR introduce a breaking change?
No