Refactor null dependency to es6#3736
Closed
timse wants to merge 2 commits into
Closed
Conversation
Member
|
@timse WOOT!!! We got dependent PR's reviewed. Go ahead and sync branch, resolve conflicts and lets see where we stand. |
Member
|
Also can you please rebase prev commits from other PR's. |
9871819 to
afa5c40
Compare
Contributor
Author
|
nice :)! done |
Contributor
Author
|
we can close this thing right :)? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
current tests should pass
If relevant, link to documentation update:
N/A
Summary
upgrade NullDependency to es6
Does this PR introduce a breaking change?
No
Other information
This PR is optimistically based on the successful merge and therefore relies on these: