Add tests for RequireJsStuffPlugin#3702
Merged
TheLarkInn merged 1 commit intowebpack:masterfrom Jan 3, 2017
Merged
Conversation
5ee8439 to
faf6d0c
Compare
TheLarkInn
approved these changes
Jan 3, 2017
Member
TheLarkInn
left a comment
There was a problem hiding this comment.
This is incredibly insightful and educational about how to cover plugins with sinon, mocking, and spying. Great job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add tests for RequireJsStuffPlugin
Did you add tests for your changes?
This PR is only tests
If relevant, link to documentation update:
N/A
Summary
Based on the coveralls report, the
RequireJsStuffPluginfile has 82% test coverage. There is noRequireJsStuffPluginspecific test file - this is added in this PR and aims to achieve 100% test coverage.https://coveralls.io/builds/9498425/source?filename=lib%2FRequireJsStuffPlugin.js
This plugin, although a higher percentage test coverage than other files, was taken on as an example of how to test nested event bindings. This PR extracts the
PluginEnvironmenthelper into a separate file, and makes use of it in order to capture internal event handlers for testing.Does this PR introduce a breaking change?
No
Other information
None