refactor(ModuleError): upgrade to ES6#3695
Merged
Merged
Conversation
Jessidhia
approved these changes
Jan 3, 2017
| constructor(module, err) { | ||
| super(); | ||
| if(Error.hasOwnProperty("captureStackTrace")) { | ||
| Error.captureStackTrace(this, this.constructor); |
Member
There was a problem hiding this comment.
This should be new.target instead of this.constructor... but Node 4 doesn't support it 😢
Member
There was a problem hiding this comment.
Once we drop Node 4 and update engine, the linter should catch this
Contributor
Author
There was a problem hiding this comment.
I notice the same @Kovensky :(
TheLarkInn
approved these changes
Jan 3, 2017
| constructor(module, err) { | ||
| super(); | ||
| if(Error.hasOwnProperty("captureStackTrace")) { | ||
| Error.captureStackTrace(this, this.constructor); |
Member
There was a problem hiding this comment.
Once we drop Node 4 and update engine, the linter should catch this
Member
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ES5 => ES6 refactor
Did you add tests for your changes?
refactor, all existing tests pass
If relevant, link to documentation update:
N/A
Summary
Helping in part of the ES6 refactor
Does this PR introduce a breaking change?
Nope