Repository navigation
Upgrade WatchIgnorePlugin to es6 - #3693
Merged
Merged
Conversation
|
|
Now tests ignoring of dirs
TheLarkInn
approved these changes
Jan 3, 2017
TheLarkInn
left a comment
Member
There was a problem hiding this comment.
Looks great. Going to have @sokra double check this one since its new and less covered. But nice test addition.
And congrats on submitting first PR.
Member
|
Alright I tested this out and looks great. Thank you so much! Congrats on your first webpack PR getting merged. 🎉 🍾 |
timse
pushed a commit
to timse/webpack
that referenced
this pull request
Jan 4, 2017
* Upgrade WatchIgnorePlugin to es6 * Improved test coverage for WatchIgnorePlugin Now tests ignoring of dirs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
Did you add tests for your changes?
Existing tests are passing
If relevant, link to documentation update:
N/A
Summary
Upgrade WatchEntryPoint to es6
Does this PR introduce a breaking change?
No