refactor(ES6): upgrade APIPlugin to ES6#3675
Merged
TheLarkInn merged 4 commits intowebpack:masterfrom Jan 2, 2017
willmendesneto:refactor-api-plugin
Merged
refactor(ES6): upgrade APIPlugin to ES6#3675TheLarkInn merged 4 commits intowebpack:masterfrom willmendesneto:refactor-api-plugin
TheLarkInn merged 4 commits intowebpack:masterfrom
willmendesneto:refactor-api-plugin
Conversation
|
|
sokra
reviewed
Jan 2, 2017
| parser.plugin("expression " + key, expr => { | ||
| const dep = new ConstDependency(REPLACEMENTS[key], expr.range); | ||
| dep.loc = expr.loc; | ||
| this.state.current.addDependency(dep); |
Contributor
Author
|
@sokra Can you take a look again, please? |
chicoxyzzy
reviewed
Jan 2, 2017
Contributor
chicoxyzzy
left a comment
There was a problem hiding this comment.
You also can rewrite all string concatenations as template strings
chicoxyzzy
approved these changes
Jan 2, 2017
Contributor
Author
Yes, for sure (good catch @chicoxyzzy ). We shouldn't add broken commits inside master branch. I don't know for now if we are not using squash as standard, but if not it's a good idea add it. |
Member
|
I'll take care of sqash. |
TheLarkInn
approved these changes
Jan 2, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
ES5 => ES6 refactor
Did you add tests for your changes?
refactor, all existing tests pass
If relevant, link to documentation update:
N/A
Summary
Helping in part of the ES6 refactor
Does this PR introduce a breaking change?
Nope