fix the illegal syntax in a module for test#3193
Merged
TheLarkInn merged 2 commits intowebpack:masterfrom Oct 27, 2016
Merged
Conversation
Member
|
Why is this illegal? |
Contributor
Author
|
you can review that issue |
Member
|
Ah ok, so it makes sense to display a warning or a Syntax error in this case? |
Contributor
Author
|
The error will be reported by acorn(the latest version).(There is another PR update the deps later) The point is should we add testcase to detect the error. |
this is related to webpack#1792, after removing the ilegal code, the code still cover the cases except case 3.
Member
|
Looks good. Test failing on AppVeyor is timeout exceeding. Created #3198 for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
#1792
The test case for harmony-export-precedence has illegal syntax.
What is the new behavior?
no syntax error
Does this PR introduce a breaking change?