Skip to content

fixed vendor when app code changes#2998

Closed
hezedu wants to merge 1 commit into
webpack:webpack-1from
hezedu:webpack-1
Closed

fixed vendor when app code changes#2998
hezedu wants to merge 1 commit into
webpack:webpack-1from
hezedu:webpack-1

Conversation

@hezedu

@hezedu hezedu commented Sep 15, 2016

Copy link
Copy Markdown

solve this bug: #1315

How to test?
#1315 (comment)

solve this bug:  #1315
sokra added a commit that referenced this pull request Sep 15, 2016
@sokra

sokra commented Sep 16, 2016

Copy link
Copy Markdown
Member

I like the idea... could work.

This fix can ensure that index is stable for for chunks.

This ensures stable order in webpack 1. If not using the occurrence order.

But webpack 2 always uses occurrence order. Here we need to ensure index order for these chunk.

I added an plugin which do so. It assigns module id by index for a chunk.

@sokra

sokra commented Sep 16, 2016

Copy link
Copy Markdown
Member

closing this because the fix was merged

@sokra sokra closed this Sep 16, 2016
@hezedu

hezedu commented Sep 16, 2016

Copy link
Copy Markdown
Author

If you continue using array index, The code-spliting's chunks will "chain change" again.

@hezedu hezedu deleted the webpack-1 branch December 29, 2016 03:37
@hezedu hezedu restored the webpack-1 branch December 29, 2016 03:37
@hezedu hezedu deleted the webpack-1 branch December 29, 2016 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants