Added support for using an ES6 default exported function for configuration#2118
Merged
sokra merged 5 commits intowebpack:masterfrom Mar 11, 2016
johanneslumpe:patch-1
Merged
Added support for using an ES6 default exported function for configuration#2118sokra merged 5 commits intowebpack:masterfrom johanneslumpe:patch-1
sokra merged 5 commits intowebpack:masterfrom
johanneslumpe:patch-1
Conversation
Allow usage of ES6 default exported function for config
Removed old code
Contributor
Author
|
Solves #2105 |
| } | ||
|
|
||
| if(typeof options === "function") { | ||
| var isES6DefaultExportedFunc = (typeof options === "object" && typeof options["default"] === "function"); |
Member
There was a problem hiding this comment.
Could you add a check for null?
var isES6DefaultExportedFunc = (options && typeof options === "object" && ...Maybe also a few lines below in my code. I've done the same mistake ;)
Contributor
Author
There was a problem hiding this comment.
Haha ;) Will add that later today!
…cessConfiguredOptions`
|
|
||
| if(typeof options === "function") { | ||
| var isES6DefaultExportedFunc = ( | ||
| typeof options === "object" && options !== null && typeof options["default"] === "function" |
There was a problem hiding this comment.
options["default"] should be rewritten as options.default, it's just cleaner that way
Contributor
Author
|
@sokra Is anything missing here? |
sokra
added a commit
that referenced
this pull request
Mar 11, 2016
Added support for using an ES6 default exported function for configuration
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.