fix(ci): use app token for triggering doc-kit#21082
Conversation
|
|
This PR is packaged and the instant preview is available (a0e3ea9). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@a0e3ea9
yarn add -D webpack@https://pkg.pr.new/webpack@a0e3ea9
pnpm add -D webpack@https://pkg.pr.new/webpack@a0e3ea9 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21082 +/- ##
==========================================
- Coverage 91.75% 91.73% -0.02%
==========================================
Files 581 581
Lines 60676 60678 +2
Branches 16423 16424 +1
==========================================
- Hits 55672 55663 -9
- Misses 5004 5015 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow to use a GitHub App installation token (instead of a stored dispatch token secret) when dispatching the webpack-doc-kit workflow after a successful publish.
Changes:
- Remove
publishedPackagesoutput wiring from thereleasejob. - Rename/adjust downstream jobs and switch the doc-kit dispatch to use
actions/create-github-app-token. - Simplify the dispatch script (but currently breaks because it still references an undefined
pkgvariable).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexander-akait
left a comment
There was a problem hiding this comment.
Please take a look at copilot review
Merging this PR will not alter performance
Comparing 
Footnotes
|
| - name: Dispatch workflow | ||
| uses: actions/github-script@d746ffe35508b1917358783b479e04febd2b8f71 # v9.0.0 | ||
| env: | ||
| PUBLISHED_PACKAGES: ${{ needs.release.outputs.publishedPackages }} | ||
| with: | ||
| github-token: ${{ secrets.DISPATCH_TOKEN }} | ||
| github-token: ${{ steps.app-token.outputs.token }} | ||
| script: | | ||
| const packages = JSON.parse(process.env.PUBLISHED_PACKAGES); | ||
| const pkg = packages.find(p => p.name === "webpack"); |
|
@avivkeller Can you fix other notes? |
No description provided.