Check for (g/s)etter support, not Object.defineProperty#2087
Merged
sokra merged 1 commit intowebpack:webpack-1from Feb 24, 2016
SimenB:getters-setters
Merged
Check for (g/s)etter support, not Object.defineProperty#2087sokra merged 1 commit intowebpack:webpack-1from SimenB:getters-setters
sokra merged 1 commit intowebpack:webpack-1from
SimenB:getters-setters
Conversation
Member
|
You need to put the function into the |
Contributor
Author
|
Yeah, I noticed! Running the tests locally now 😄 |
Contributor
Author
|
Done. BTW, the examples-tests fails for me. Any idea why?
|
Member
|
npm is weird and installs |
Member
|
Instead clone the webpack repo into a |
Contributor
Author
|
Ah, fancy! |
|
Is it going to be merged into v2 branch as well? |
sokra
added a commit
that referenced
this pull request
Feb 24, 2016
Check for (g/s)etter support, not Object.defineProperty
Member
|
Thanks |
Member
Nope. v2 depends on Object.defineProperty anyway for the ES6 stuff. v2 doesn't support IE8! |
Contributor
Author
|
@sokra Could you publish this? |
Contributor
Author
|
@sokra ping 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #2085