fix: asset/source namespace should only contain "default" export#20672
Open
xiaoxiaojx wants to merge 8 commits into
Open
fix: asset/source namespace should only contain "default" export#20672xiaoxiaojx wants to merge 8 commits into
xiaoxiaojx wants to merge 8 commits into
Conversation
Contributor
|
This PR is packaged and the instant preview is available (a46af0a). Install it locally:
npm i -D webpack@https://pkg.pr.new/webpack@b511cd2
yarn add -D webpack@https://pkg.pr.new/webpack@b511cd2
pnpm add -D webpack@https://pkg.pr.new/webpack@b511cd2 |
0d696b9 to
f414129
Compare
🦋 Changeset detectedLatest commit: a46af0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I am afraid it can break some libraries, technically you can bundle library which has |
f414129 to
efb4b8c
Compare
efb4b8c to
d028963
Compare
d028963 to
0011e06
Compare
Member
Author
|
@alexander-akait We now follow the same approach as JSON modules: when imported via with { type: "text" } (spec |
| */ | ||
| constructor({ exportsType = /** @type {"default"} */ ("default") } = {}) { | ||
| super(); | ||
| this._exportsType = exportsType; |
Member
There was a problem hiding this comment.
I think we should not rely on this, I mean let's avoid generation of __esModule only when output.module is true, so it will be safe and no breaking change
Contributor
Types CoverageCoverage after merging fix/text-via-namespace into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
themavik
reviewed
Mar 23, 2026
themavik
left a comment
There was a problem hiding this comment.
curl test review please ignore if duplicate
Contributor
|
Never mind. |
Member
|
@magic-akari yeah, it is not related, but source import is on our roadmap too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per CreateDefaultExportSyntheticModule spec (tc39/proposal-import-text, tc39/proposal-json-modules), the namespace export list is « "default" ».
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing