define call should include empty dependencies list#1368
Merged
sokra merged 1 commit intowebpack:masterfrom Aug 24, 2015
Merged
Conversation
see: umdjs/umd#34 > Without this, the factory may be scanned for additional dependencies matching the literal string require("module-id"), which is not correct. See https://github.com/amdjs/amdjs-api/wiki/AMD#simplified-commonjs-wrapping-.
Contributor
Author
|
This PR should also include this fix umdjs/umd@6e69315 |
Contributor
Author
|
And this umdjs/umd#22 |
sokra
added a commit
that referenced
this pull request
Aug 24, 2015
define call should include empty dependencies list
Member
|
Thanks. Do you want to do another PR for the other fixes? |
Contributor
Author
|
Yep. Will do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: umdjs/umd#34