Skip to content

Link fix: Link to "is empty" not "empty" when an adjective is intended #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fdwr merged 2 commits into from
Jun 17, 2024
Merged

Link fix: Link to "is empty" not "empty" when an adjective is intended #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66719f7
Link fix: Link to "is empty" not "empty" when a noun is intended
inexorabletash Jun 13, 2024
5afa97c
Apply suggestions from code review
fdwr Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ Build a composed graph up to a given output operand into a computational graph a
1. Let |operators| be a new empty [=/set=].
1. Let |inputs| be a new empty [=/set=].
1. Let |queue| be a new [=queue=] containing |outputs|'s [=map/values=].
1. While |queue| is not [=queue/empty=]:
1. While |queue| [=queue/is not empty=]:
1. [=queue/Dequeue=] |operand| from |queue|.
1. [=set/Append=] |operand| to |operands|.
1. [=set/Append=] |operand|.{{MLOperand/[[operator]]}} to |operators|.
Expand Down
5 changes: 5 additions & 0 deletions tools/lint.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,4 +273,9 @@ for (const match of source.matchAll(/^ *\d+\. .*$/mg)) {
}
}

// Avoid incorrect links to list/empty.
for (const match of source.matchAll(/is( not)? \[=(list\/|stack\/|queue\/|)empty=\]/g)) {
error(`Link to 'is empty' (adjective) not 'empty' (verb): ${format(match)}`);
}

globalThis.process.exit(exitCode);