URL: ToASCII by annevk · Pull Request #5976 · web-platform-tests/wpt

annevk · 2017-05-18T10:14:11Z

Tests for whatwg/url#53 and friends.

annevk · 2017-05-18T10:16:34Z

@rmisev would you be interested in reviewing this? I included tests you created for whatwg/url#309. I'll also go ahead and file issues against all browsers so we get ToASCII handling consistent, even when the input is just ASCII. I suppose I'll also file an issue against Node.js.

annevk · 2017-05-18T10:20:04Z

(This is basically a much simplified version of #4504, to get the high-level issues between implementations ironed out first.)

ghost · 2017-05-18T10:27:13Z

*This report has been truncated because the total content is 252267 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision b5d96af
Using browser at version BuildID 20170601100220; SourceStamp bdb2387396b4a74dfefb7c983733eed3625e906a
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/toascii.window.html

Subtest	Results	Messages
	OK
`Loading dataâ�¦`	PASS
`aa-- (using URL)`	PASS
`aa-- (using URL.host)`	PASS
`aa-- (using URL.hostname)`	PASS
`aa-- (using <a>)`	PASS
`aa-- (using <a>.host)`	PASS
`aa-- (using <a>.hostname)`	PASS
`aa-- (using <area>)`	PASS
`aa-- (using <area>.host)`	PASS
`aa-- (using <area>.hostname)`	PASS
`aâ� -- (using URL)`	PASS
`aâ� -- (using URL.host)`	PASS
`aâ� -- (using URL.hostname)`	PASS
`aâ� -- (using <a>)`	PASS
`aâ� -- (using <a>.host)`	PASS
`aâ� -- (using <a>.hostname)`	PASS
`aâ� -- (using <area>)`	PASS
`aâ� -- (using <area>.host)`	PASS
`aâ� -- (using <area>.hostname)`	PASS
`ab--c (using URL)`	PASS
`ab--c (using URL.host)`	PASS
`ab--c (using URL.hostname)`	PASS
`ab--c (using <a>)`	PASS
`ab--c (using <a>.host)`	PASS
`ab--c (using <a>.hostname)`	PASS
`ab--c (using <area>)`	PASS
`ab--c (using <area>.host)`	PASS
`ab--c (using <area>.hostname)`	PASS
`-x (using URL)`	PASS
`-x (using URL.host)`	PASS
`-x (using URL.hostname)`	PASS
`-x (using <a>)`	PASS
`-x (using <a>.host)`	PASS
`-x (using <a>.hostname)`	PASS
`-x (using <area>)`	PASS
`-x (using <area>.host)`	PASS
`-x (using <area>.hostname)`	PASS
`-â� (using URL)`	PASS
`-â� (using URL.host)`	PASS
`-â� (using URL.hostname)`	PASS
`-â� (using <a>)`	PASS
`-â� (using <a>.host)`	PASS
`-â� (using <a>.hostname)`	PASS
`-â� (using <area>)`	PASS
`-â� (using <area>.host)`	PASS
`-â� (using <area>.hostname)`	PASS
`-x.xn--nxa (using URL)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using URL.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using URL.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <a>)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <a>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <a>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <area>)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <area>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.xn--nxa (using <area>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using URL)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using URL.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using URL.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <a>)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <a>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <a>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <area>)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <area>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`-x.Î² (using <area>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.Î²"`
`x-.xn--nxa (using URL)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using URL.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using URL.hostname)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <a>)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <a>.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <a>.hostname)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <area>)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <area>.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got "x-.Î²"`
`x-.xn--nxa (using <area>.hostname)`

ghost · 2017-05-18T10:27:13Z

*This report has been truncated because the total content is 177786 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision b5d96af
Using browser at version 10.0
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/toascii.window.html

Subtest	Results	Messages
	OK
`Loading dataâ�¦`	PASS
`aa-- (using URL)`	PASS
`aa-- (using URL.host)`	PASS
`aa-- (using URL.hostname)`	PASS
`aa-- (using <a>)`	PASS
`aa-- (using <a>.host)`	PASS
`aa-- (using <a>.hostname)`	PASS
`aa-- (using <area>)`	PASS
`aa-- (using <area>.host)`	PASS
`aa-- (using <area>.hostname)`	PASS
`aâ� -- (using URL)`	PASS
`aâ� -- (using URL.host)`	PASS
`aâ� -- (using URL.hostname)`	PASS
`aâ� -- (using <a>)`	PASS
`aâ� -- (using <a>.host)`	PASS
`aâ� -- (using <a>.hostname)`	PASS
`aâ� -- (using <area>)`	PASS
`aâ� -- (using <area>.host)`	PASS
`aâ� -- (using <area>.hostname)`	PASS
`ab--c (using URL)`	PASS
`ab--c (using URL.host)`	PASS
`ab--c (using URL.hostname)`	PASS
`ab--c (using <a>)`	PASS
`ab--c (using <a>.host)`	PASS
`ab--c (using <a>.hostname)`	PASS
`ab--c (using <area>)`	PASS
`ab--c (using <area>.host)`	PASS
`ab--c (using <area>.hostname)`	PASS
`-x (using URL)`	PASS
`-x (using URL.host)`	PASS
`-x (using URL.hostname)`	PASS
`-x (using <a>)`	PASS
`-x (using <a>.host)`	PASS
`-x (using <a>.hostname)`	PASS
`-x (using <area>)`	PASS
`-x (using <area>.host)`	PASS
`-x (using <area>.hostname)`	PASS
`-â� (using URL)`	PASS
`-â� (using URL.host)`	PASS
`-â� (using URL.hostname)`	PASS
`-â� (using <a>)`	PASS
`-â� (using <a>.host)`	PASS
`-â� (using <a>.hostname)`	PASS
`-â� (using <area>)`	PASS
`-â� (using <area>.host)`	PASS
`-â� (using <area>.hostname)`	PASS
`-x.xn--nxa (using URL)`	PASS
`-x.xn--nxa (using URL.host)`	PASS
`-x.xn--nxa (using URL.hostname)`	PASS
`-x.xn--nxa (using <a>)`	PASS
`-x.xn--nxa (using <a>.host)`	PASS
`-x.xn--nxa (using <a>.hostname)`	PASS
`-x.xn--nxa (using <area>)`	PASS
`-x.xn--nxa (using <area>.host)`	PASS
`-x.xn--nxa (using <area>.hostname)`	PASS
`-x.Î² (using URL)`	PASS
`-x.Î² (using URL.host)`	PASS
`-x.Î² (using URL.hostname)`	PASS
`-x.Î² (using <a>)`	PASS
`-x.Î² (using <a>.host)`	PASS
`-x.Î² (using <a>.hostname)`	PASS
`-x.Î² (using <area>)`	PASS
`-x.Î² (using <area>.host)`	PASS
`-x.Î² (using <area>.hostname)`	PASS
`x-.xn--nxa (using URL)`	PASS
`x-.xn--nxa (using URL.host)`	PASS
`x-.xn--nxa (using URL.hostname)`	PASS
`x-.xn--nxa (using <a>)`	PASS
`x-.xn--nxa (using <a>.host)`	PASS
`x-.xn--nxa (using <a>.hostname)`	PASS
`x-.xn--nxa (using <area>)`	PASS
`x-.xn--nxa (using <area>.host)`	PASS
`x-.xn--nxa (using <area>.hostname)`	PASS
`x-.Î² (using URL)`	PASS
`x-.Î² (using URL.host)`	PASS
`x-.Î² (using URL.hostname)`	PASS
`x-.Î² (using <a>)`	PASS
`x-.Î² (using <a>.host)`	PASS
`x-.Î² (using <a>.hostname)`	PASS
`x-.Î² (using <area>)`	PASS
`x-.Î² (using <area>.host)`	PASS
`x-.Î² (using <area>.hostname)`	PASS
`x..xn--nxa (using URL)`	PASS
`x..xn--nxa (using URL.host)`	PASS
`x..xn--nxa (using URL.hostname)`	PASS
`x..xn--nxa (using <a>)`	PASS
`x..xn--nxa (using <a>.host)`	PASS
`x..xn--nxa (using <a>.hostname)`	PASS
`x..xn--nxa (using <area>)`	PASS
`x..xn--nxa (using <area>.host)`	PASS
`x..xn--nxa (using <area>.hostname)`	PASS
`x..Î² (using URL)`	FAIL	`Type error`
`x..Î² (using URL.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`x..Î² (using URL.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`x..Î² (using <a>)`	FAIL	`Type error`
`x..Î² (using <a>.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`x..Î² (using <a>.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`x..Î² (using <area>)`	FAIL	`Type error`
`x..Î² (using <area>.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`x..Î² (using <area>.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got "x"`
`xn--a (using URL)`	FAIL	`assert_throws: function "() => makeURL("url", hostTest.input)" did not throw`
`xn--a (using URL.host)`	FAIL	`assert_equals: expected "x" but got "xn--a"`
`xn--a (using URL.hostname)`	FAIL	`assert_equals: expected "x" but got "xn--a"`
`xn--a (using <a>)`	FAIL	`assert_equals: expected "" but got "xn--a"`

|

ghost · 2017-05-18T10:27:14Z

*This report has been truncated because the total content is 182604 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision b5d96af
Using browser at version 60.0.3112.10 dev
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/toascii.window.html

Subtest	Results	Messages
	OK
`Loading data…`	PASS
`aa-- (using URL)`	PASS
`aa-- (using URL.host)`	PASS
`aa-- (using URL.hostname)`	PASS
`aa-- (using <a>)`	PASS
`aa-- (using <a>.host)`	PASS
`aa-- (using <a>.hostname)`	PASS
`aa-- (using <area>)`	PASS
`aa-- (using <area>.host)`	PASS
`aa-- (using <area>.hostname)`	PASS
`a†-- (using URL)`	FAIL	`Failed to construct 'URL': Invalid URL`
`a†-- (using URL.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`a†-- (using URL.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`a†-- (using <a>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`a†-- (using <a>.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`a†-- (using <a>.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`a†-- (using <area>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`a†-- (using <area>.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`a†-- (using <area>.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got ""`
`ab--c (using URL)`	PASS
`ab--c (using URL.host)`	PASS
`ab--c (using URL.hostname)`	PASS
`ab--c (using <a>)`	PASS
`ab--c (using <a>.host)`	PASS
`ab--c (using <a>.hostname)`	PASS
`ab--c (using <area>)`	PASS
`ab--c (using <area>.host)`	PASS
`ab--c (using <area>.hostname)`	PASS
`-x (using URL)`	PASS
`-x (using URL.host)`	PASS
`-x (using URL.hostname)`	PASS
`-x (using <a>)`	PASS
`-x (using <a>.host)`	PASS
`-x (using <a>.hostname)`	PASS
`-x (using <area>)`	PASS
`-x (using <area>.host)`	PASS
`-x (using <area>.hostname)`	PASS
`-† (using URL)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-† (using URL.host)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-† (using URL.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-† (using <a>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-† (using <a>.host)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-† (using <a>.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-† (using <area>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-† (using <area>.host)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-† (using <area>.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got ""`
`-x.xn--nxa (using URL)`	PASS
`-x.xn--nxa (using URL.host)`	PASS
`-x.xn--nxa (using URL.hostname)`	PASS
`-x.xn--nxa (using <a>)`	PASS
`-x.xn--nxa (using <a>.host)`	PASS
`-x.xn--nxa (using <a>.hostname)`	PASS
`-x.xn--nxa (using <area>)`	PASS
`-x.xn--nxa (using <area>.host)`	PASS
`-x.xn--nxa (using <area>.hostname)`	PASS
`-x.β (using URL)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-x.β (using URL.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`-x.β (using URL.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`-x.β (using <a>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-x.β (using <a>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`-x.β (using <a>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`-x.β (using <area>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`-x.β (using <area>.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`-x.β (using <area>.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got ""`
`x-.xn--nxa (using URL)`	PASS
`x-.xn--nxa (using URL.host)`	PASS
`x-.xn--nxa (using URL.hostname)`	PASS
`x-.xn--nxa (using <a>)`	PASS
`x-.xn--nxa (using <a>.host)`	PASS
`x-.xn--nxa (using <a>.hostname)`	PASS
`x-.xn--nxa (using <area>)`	PASS
`x-.xn--nxa (using <area>.host)`	PASS
`x-.xn--nxa (using <area>.hostname)`	PASS
`x-.β (using URL)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x-.β (using URL.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x-.β (using URL.hostname)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x-.β (using <a>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x-.β (using <a>.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x-.β (using <a>.hostname)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x-.β (using <area>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x-.β (using <area>.host)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x-.β (using <area>.hostname)`	FAIL	`assert_equals: expected "x-.xn--nxa" but got ""`
`x..xn--nxa (using URL)`	PASS
`x..xn--nxa (using URL.host)`	PASS
`x..xn--nxa (using URL.hostname)`	PASS
`x..xn--nxa (using <a>)`	PASS
`x..xn--nxa (using <a>.host)`	PASS
`x..xn--nxa (using <a>.hostname)`	PASS
`x..xn--nxa (using <area>)`	PASS
`x..xn--nxa (using <area>.host)`	PASS
`x..xn--nxa (using <area>.hostname)`	PASS
`x..β (using URL)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x..β (using URL.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`x..β (using URL.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`x..β (using <a>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x..β (using <a>.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`x..β (using <a>.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`x..β (using <area>)`	FAIL	`Failed to construct 'URL': Invalid URL`
`x..β (using <area>.host)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`x..β (using <area>.hostname)`	FAIL	`assert_equals: expected "x..xn--nxa" but got ""`
`xn--a (using URL)`	FAIL	`assert_throws: function "() => makeURL("url", hostTest.input)" did not throw`
`xn--a (using URL.host)`	FAIL	`assert_equals: expected "x" but got "xn--a"`
`xn--a (using URL.hostname)`	FAIL	`assert_equals: expected "x" but got "xn--a"`
`xn--a (using <a>)`	FAIL	`assert_equals: expected "" but got "xn--a"`
`xn--a (using <a>.host)`

ghost · 2017-05-18T10:27:14Z

*This report has been truncated because the total content is 259355 characters in length, which is in excess of GitHub.com's limit for comments (65536 characters).

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision b5d96af
Using browser at version 14.14393
Starting 10 test iterations
All results were stable

All results

1 test ran

/url/toascii.window.html

Subtest	Results	Messages
	OK
`Loading data…`	PASS
`aa-- (using URL)`	PASS
`aa-- (using URL.host)`	PASS
`aa-- (using URL.hostname)`	PASS
`aa-- (using <a>)`	PASS
`aa-- (using <a>.host)`	PASS
`aa-- (using <a>.hostname)`	PASS
`aa-- (using <area>)`	PASS
`aa-- (using <area>.host)`	PASS
`aa-- (using <area>.hostname)`	PASS
`a†-- (using URL)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using URL.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using URL.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <a>)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <a>.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <a>.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <area>)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <area>.host)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`a†-- (using <area>.hostname)`	FAIL	`assert_equals: expected "xn--a---kp0a" but got "a†--"`
`ab--c (using URL)`	PASS
`ab--c (using URL.host)`	PASS
`ab--c (using URL.hostname)`	PASS
`ab--c (using <a>)`	PASS
`ab--c (using <a>.host)`	PASS
`ab--c (using <a>.hostname)`	PASS
`ab--c (using <area>)`	PASS
`ab--c (using <area>.host)`	PASS
`ab--c (using <area>.hostname)`	PASS
`-x (using URL)`	PASS
`-x (using URL.host)`	PASS
`-x (using URL.hostname)`	PASS
`-x (using <a>)`	PASS
`-x (using <a>.host)`	PASS
`-x (using <a>.hostname)`	PASS
`-x (using <area>)`	PASS
`-x (using <area>.host)`	PASS
`-x (using <area>.hostname)`	PASS
`-† (using URL)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using URL.host)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using URL.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <a>)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <a>.host)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <a>.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <area>)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <area>.host)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-† (using <area>.hostname)`	FAIL	`assert_equals: expected "xn----xhn" but got "-†"`
`-x.xn--nxa (using URL)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using URL.host)`	PASS
`-x.xn--nxa (using URL.hostname)`	PASS
`-x.xn--nxa (using <a>)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using <a>.host)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using <a>.hostname)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using <area>)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using <area>.host)`	FAIL	`Unspecified error.`
`-x.xn--nxa (using <area>.hostname)`	FAIL	`Unspecified error.`
`-x.β (using URL)`	FAIL	`Unspecified error.`
`-x.β (using URL.host)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.β"`
`-x.β (using URL.hostname)`	FAIL	`assert_equals: expected "-x.xn--nxa" but got "-x.β"`
`-x.β (using <a>)`	FAIL	`Unspecified error.`
`-x.β (using <a>.host)`	FAIL	`Unspecified error.`
`-x.β (using <a>.hostname)`	FAIL	`Unspecified error.`
`-x.β (using <area>)`	FAIL	`Unspecified error.`
`-x.β (using <area>.host)`	FAIL	`Unspecified error.`
`-x.β (using <area>.hostname)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using URL)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using URL.host)`	PASS
`x-.xn--nxa (using URL.hostname)`	PASS
`x-.xn--nxa (using <a>)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using <a>.host)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using <a>.hostname)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using <area>)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using <area>.host)`	FAIL	`Unspecified error.`
`x-.xn--nxa (using <area>.hostname)`	FAIL	`Unspecified error.`

rmisev · 2017-05-18T21:15:21Z

I see some uncovered cases. The following tests can be added:

Leading/trailing hyphens:
-x.xn--nxa
-x.β
x-.xn--nxa
x-.β
Empty labels:
x..xn--nxa
x..β
Labels longer than 63 code points:
x01234567890123456789012345678901234567890123456789012345678901x.xn--nxa
x01234567890123456789012345678901234567890123456789012345678901x.β

I checked only tests (no test code) and they LGTM.

annevk · 2017-05-19T07:54:57Z

Maybe we should also test domain longer than 255 with labels shorter than 63.

rmisev · 2017-05-19T09:59:29Z

Yes, makes sense.

Tests for whatwg/url#53 and friends.

…rs for later)

annevk · 2017-05-24T10:42:11Z

@rmisev could you review once more? It seems Chrome would rather have this merged and then evaluate.

Tests: web-platform-tests/wpt#5976. Fixes #53 and fixes #267 by no longer breaking on on hyphens in the 3rd and 4th position of a domain label. This is known to break YouTube: r3---sn-2gb7ln7k.googlevideo.com. This is done by setting the proposed CheckHyphens flag to false. Fixes #110 by clarifying that BIDI and CONTEXTJ checks are to be done by setting the proposed CheckBidi and CheckJoiners flags to true. Follow-up #313 is filed to remove the proposed bits once Unicode is updated.

rmisev · 2017-05-24T21:06:25Z

I think the tests are OK, but I suggest adding two more tests to highlight the fast path problem:

"\u200D.example" in Punycode (CheckJoiners test)

  {
    "input": "xn--1ug.example",
    "output": null
  },

"يa" in Punycode (CheckBidi test)

  {
    "input": "xn--a-yoc",
    "output": null
  },

annevk · 2017-05-25T04:56:58Z

Good call! (And thanks for figuring out the Punycode.)

domenic · 2017-05-31T19:38:47Z

+    if (typeof hostTest === "string") {
+      continue // skip comments
+    }
+    if(hostTest.output === undefined) {


I would prefer that this kind of normalization be done ahead of time, so that there is less logic in the tests. I will push a commit to fix.

TimothyGu · 2017-06-01T06:25:11Z

We have another one in Node.js:

  {
    "comment": "Forbidden character",
    "input": "\uFFFD.com",
    "output": null
  },

rmisev · 2017-06-01T08:04:39Z

... and the same encoded:

  {
    "comment": "U+FFFD character encoded in Punycode",
    "input": "xn--zn7c.com",
    "output": null
  },

Tests: web-platform-tests/wpt#5976. Fixes #53 and fixes #267 by no longer breaking on hyphens in the 3rd and 4th position of a domain label. This is known to break YouTube: r3---sn-2gb7ln7k.googlevideo.com. This is fixed by setting the proposed CheckHyphens flag to false. Fixes #110 by clarifying that BIDI and CONTEXTJ checks are to be done by setting the proposed CheckBidi and CheckJoiners flags to true. Follow-up #313 is filed to remove the proposed bits once Unicode is updated. #317 also tracks a potential cleanup.

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: nodejs#13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: nodejs#13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Follows whatwg/url#309 Tests web-platform-tests/wpt#5976

wpt-pr-bot added the url label May 18, 2017

wpt-pr-bot requested review from Sebmaster, domenic, mikewest, rubys, smola, tomalec, xiaojunwu and zcorpan May 18, 2017 10:14

annevk mentioned this pull request May 18, 2017

Perhaps do not apply ToASCII for ASCII-only input whatwg/url#267

Closed

annevk mentioned this pull request May 19, 2017

Bot results cannot handle Unicode #5998

Closed

URL: ToASCII

192384e

Tests for whatwg/url#53 and friends.

annevk force-pushed the annevk/url-toascii branch from 3a97ad9 to 192384e Compare May 19, 2017 12:08

annevk added 2 commits May 19, 2017 14:26

Add more tests, move 63 code point tests to the end for readability

530adbf

CheckJoiners should probably be true (leave testing emojis with joine…

a302090

…rs for later)

add ASCII-only CheckJoiners/CheckBidi tests

ded5d2f

domenic reviewed May 31, 2017

View reviewed changes

Explicitly state output in all cases

762a7a6

domenic mentioned this pull request May 31, 2017

Disable check hyphens flag jsdom/whatwg-url#90

Closed

TimothyGu mentioned this pull request Jun 1, 2017

url, i18n: update IDNA handling nodejs/node#13362

Closed

3 tasks

Add extra Node.js test cases

b544f3d

domenic approved these changes Jun 1, 2017

View reviewed changes

domenic merged commit ded8ffe into master Jun 1, 2017

domenic deleted the annevk/url-toascii branch June 1, 2017 21:54

TimothyGu added a commit to TimothyGu/node that referenced this pull request Jun 7, 2017

url: update IDNA handling

48dc28e

Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976

rmisev added a commit to upa-url/upa that referenced this pull request May 24, 2020

Add ToASCII: CheckHyphens = false

9cbc9c0

Follows whatwg/url#309 Tests web-platform-tests/wpt#5976

Conversation

annevk commented May 18, 2017 • edited by wpt-pr-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk commented May 18, 2017

Uh oh!

annevk commented May 18, 2017

Uh oh!

ghost commented May 18, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Firefox (nightly)

All results

Uh oh!

ghost commented May 18, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sauce (safari)

All results

Uh oh!

ghost commented May 18, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chrome (unstable)

All results

Uh oh!

ghost commented May 18, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sauce (MicrosoftEdge)

All results

Uh oh!

rmisev commented May 18, 2017

Uh oh!

annevk commented May 19, 2017

Uh oh!

rmisev commented May 19, 2017

Uh oh!

annevk commented May 24, 2017

Uh oh!

rmisev commented May 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

annevk commented May 25, 2017

Uh oh!

domenic May 31, 2017

Choose a reason for hiding this comment

Uh oh!

TimothyGu commented Jun 1, 2017

Uh oh!

rmisev commented Jun 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

annevk commented May 18, 2017 •

edited by wpt-pr-bot

Loading

ghost commented May 18, 2017 •

edited by ghost

Loading

ghost commented May 18, 2017 •

edited by ghost

Loading

ghost commented May 18, 2017 •

edited by ghost

Loading

ghost commented May 18, 2017 •

edited by ghost

Loading

rmisev commented May 24, 2017 •

edited

Loading