webnn: refactor WebNN API conformance tests infrastructure#47291
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Jul 25, 2024
Merged
webnn: refactor WebNN API conformance tests infrastructure#47291chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This CL is to refactor WebNN API conformance tests infrastructure by optimizing utils.js helper and moving tests from JSON files into each test file. It also removes tests of dropped `constant(fillSequence)` op of WebNN API changes [1]. [1] [Remove sequential filling overload of constant()](webmachinelearning/webnn#656) Bug: 331692961 Change-Id: Ie57095d76ed1a87bcbd93dbade8962a1d4461627 Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5668527 Auto-Submit: Feng Dai <feng.dai@intel.com> Commit-Queue: Feng Dai <feng.dai@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Reviewed-by: David Baron <dbaron@chromium.org> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1332944}
8cd97d4 to
723e52f
Compare
wpt-pr-bot
approved these changes
Jul 25, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL is to refactor WebNN API conformance tests infrastructure by
optimizing utils.js helper and moving tests from JSON files into each
test file.
It also removes tests of dropped
constant(fillSequence)op of WebNN APIchanges [1].
[1] Remove sequential filling overload of
constant()
Bug: 331692961
Change-Id: Ie57095d76ed1a87bcbd93dbade8962a1d4461627
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5668527
Auto-Submit: Feng Dai <feng.dai@intel.com>
Commit-Queue: Feng Dai <feng.dai@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Reviewed-by: David Baron <dbaron@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332944}