Reland "webnn: Enforce input data type constraints for gather indices"#46217
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom May 23, 2024
Merged
Reland "webnn: Enforce input data type constraints for gather indices"#46217chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
0191526 to
e76cd75
Compare
This is a reland of commit ef29e11bfb1f1f4eae0935fb58f0e4129620837b The failure of services_unittests/WebNNGraphImplBackendTest. BuildAndComputeSingleOperatorGather has been fixed by another CL: https://chromium-review.googlesource.com/c/chromium/src/+/5544945. This CL adds int32 dataType support check besides uint32 and int64 for gather indices compared with original CL. Original change's description: > webnn: Enforce input data type constraints for gather indices > > As specified in webmachinelearning/webnn#646 > > Bug: 328567884 > Change-Id: I33eba7e1def430b1cb94e3e7a4868e82c5bbd9a3 > Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5520313 > Reviewed-by: Austin Sullivan <asully@chromium.org> > Commit-Queue: Lisha Guo <lisha.guo@intel.com> > Reviewed-by: ningxin hu <ningxin.hu@intel.com> > Cr-Commit-Position: refs/heads/main@{#1298443} Bug: 328567884 Change-Id: Ide6a0e1bc6d3ebea7dce6bf37da4318e7b6e1bd1 Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,gpu-fyi-try-win11-qualcomm-rel-64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532907 Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Lisha Guo <lisha.guo@intel.com> Reviewed-by: Austin Sullivan <asully@chromium.org> Cr-Commit-Position: refs/heads/main@{#1304870}
e76cd75 to
5145a95
Compare
wpt-pr-bot
approved these changes
May 23, 2024
Collaborator
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a reland of commit ef29e11bfb1f1f4eae0935fb58f0e4129620837b
The failure of services_unittests/WebNNGraphImplBackendTest.
BuildAndComputeSingleOperatorGather has been fixed by another CL: https://chromium-review.googlesource.com/c/chromium/src/+/5544945.
This CL adds int32 dataType support check besides uint32 and int64 for
gather indices compared with original CL.
Original change's description:
Bug: 328567884
Change-Id: Ide6a0e1bc6d3ebea7dce6bf37da4318e7b6e1bd1
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,gpu-fyi-try-win11-qualcomm-rel-64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5532907
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Lisha Guo <lisha.guo@intel.com>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1304870}