URL: Add some possible bugs seen in implementation#29271
Merged
domenic merged 1 commit intoweb-platform-tests:masterfrom Jun 8, 2021
Merged
URL: Add some possible bugs seen in implementation#29271domenic merged 1 commit intoweb-platform-tests:masterfrom
domenic merged 1 commit intoweb-platform-tests:masterfrom
Conversation
3 tasks
bl-ue
approved these changes
Jun 8, 2021
There was a problem hiding this comment.
I'm assuming this has to do with nodejs/node#38963? Ah, I see that nodejs/node#36559 is a dupe of that issue.
domenic
approved these changes
Jun 8, 2021
Member
domenic
left a comment
There was a problem hiding this comment.
LGTM although I guess some of this might change per discussions in https://bugs.webkit.org/show_bug.cgi?id=127970#c8. Let's merge for now and we can update later if necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collected from:
new URLgives wrong result on leading backslash nodejs/node#36559