Changes URL tests for file path normalisation proposal#25716
Merged
annevk merged 2 commits intoweb-platform-tests:masterfrom Sep 30, 2020
alwinb:pr-whatwg-url-issue-405
Merged
Changes URL tests for file path normalisation proposal#25716annevk merged 2 commits intoweb-platform-tests:masterfrom alwinb:pr-whatwg-url-issue-405
annevk merged 2 commits intoweb-platform-tests:masterfrom
alwinb:pr-whatwg-url-issue-405
Conversation
annevk
approved these changes
Sep 28, 2020
Member
annevk
left a comment
There was a problem hiding this comment.
Thanks for writing these! This looks correct to me modulo the nit.
| "username": "user" | ||
| } | ||
| ] | ||
| ] No newline at end of file |
Member
There was a problem hiding this comment.
Please restore the newline at the end.
Contributor
Author
There was a problem hiding this comment.
Ah, I didn't see that.
Contributor
Author
There was a problem hiding this comment.
Just so I know how this works, does each such commit send out another approval request to each of the reviewers?
Member
There was a problem hiding this comment.
I think that depends on how you configure your GitHub notifications, but maybe? I usually wait for some kind of comment before taking another look.
domenic
approved these changes
Sep 29, 2020
annevk
pushed a commit
to whatwg/url
that referenced
this pull request
Sep 30, 2020
Applicable only to file URLs: - Leading empty path segments are no longer removed. - If absent, the host is copied from the base URL. - Otherwise the host is preserved with one exception: if the host is `localhost`, then it is set to the empty string. Tests: web-platform-tests/wpt#25716. JS implementation: jsdom/whatwg-url#170. Fixes #302 and fixes #402.
This was referenced Sep 30, 2020
3 tasks
philn
pushed a commit
to philn/old-webkit
that referenced
this pull request
Oct 4, 2020
https://bugs.webkit.org/show_bug.cgi?id=217170 Reviewed by Brady Eidson. LayoutTests/imported/w3c: * web-platform-tests/url/a-element-expected.txt: * web-platform-tests/url/a-element-xhtml-expected.txt: * web-platform-tests/url/resources/urltestdata.json: * web-platform-tests/url/url-constructor-expected.txt: Source/WTF: This matches Chrome and the URL specification. Covered by newly passing web platform tests. I also updated the web platform tests from web-platform-tests/wpt#25716 which aligns with Safari in cases except copying of the host from base file URLs. The implementation pushes copying from the base URL downstream in the parsing process to where it is in the URL specification so that we can properly decide how much of the base URL to copy and so we can copy it into the right place in the result URL. I also updated an assertion that makes sure that we re-use the input String if possible because there are cases where we copy part of the parent URL, which is a "syntax violation" (meaning we copy the string parts and assemble a new one), then re-assemble a new String that is equal to the input string. This is not a problem, it just needed to be reflected in the assertion. * wtf/URLParser.cpp: (WTF::URLParser::URLParser): (WTF::URLParser::parse): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267896 268f45cc-cd09-0410-ab3c-d52691b4dbfc
watilde
added a commit
to watilde/node
that referenced
this pull request
Oct 5, 2020
watilde
added a commit
to nodejs/node
that referenced
this pull request
Oct 12, 2020
Refs: whatwg/url#544 Refs: web-platform-tests/wpt#25716 PR-URL: #35477 Fixes: #35429 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: whatwg/url#544 Refs: web-platform-tests/wpt#25716 PR-URL: nodejs#35477 Fixes: nodejs#35429 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the URL tests (urltestdata.json and setters_tests.json) for the proposal outlined in whatwg/url#405.