Skip to content

chore(crates): use OIDC to publish crates - #13543

Merged
hardfist merged 5 commits into
mainfrom
chore/crate_oicd_pub
Mar 31, 2026
Merged

chore(crates): use OIDC to publish crates#13543
hardfist merged 5 commits into
mainfrom
chore/crate_oicd_pub

Conversation

@stormslowly

@stormslowly stormslowly commented Mar 31, 2026 •
edited by hardfist
Loading

Copy link
Copy Markdown
Contributor

Summary

use OIDC publish for safety reason

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings March 31, 2026 04:54
@github-actions github-actions Bot added the team The issue/pr is created by the member of Rspack. label Mar 31, 2026
Copilot AI reviewed Mar 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the crates release reusable workflow to publish to crates.io using GitHub OIDC (tokenless auth) instead of a long-lived CARGO_REGISTRY_TOKEN secret, aligning crate publishing with modern provenance-oriented release practices.

Changes:

  • Adds rust-lang/crates-io-auth-action to mint a crates.io token via OIDC.
  • Switches crate-publish to use the OIDC-minted token (steps.auth.outputs.token) instead of secrets.CARGO_REGISTRY_TOKEN.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/reusable-release-crates.yml
@codspeed

codspeed Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will degrade performance by 1.79%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 14 untouched benchmarks
⏩ 19 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation rust@concatenate_module_code_generation 144 ms 146.6 ms -1.79%
⚡ Simulation rust@create_chunk_ids 10.7 ms 10.4 ms +3.41%

Comparing chore/crate_oicd_pub (8c6c3ef) with main (3686501)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@github-actions

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB 0
react-1k 826.3 KB 0
react-5k 2.7 MB 0
rome 984.2 KB 0
ui-components 2.3 MB 0

Generated by Rsdoctor GitHub Action

@github-actions

github-actions Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Binary Size-limit

Comparing 8c6c3ef to chore: useNapiCross for x64 linux gnu compilation (#13539) by CPunisher

🎉 Size decreased by 11.09KB from 49.06MB to 49.05MB (⬇️0.02%)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Mar 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying rspack with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8c6c3ef
Status: ✅  Deploy successful!
Preview URL: https://b26c2c49.rspack-v2.pages.dev
Branch Preview URL: https://chore-crate-oicd-pub.rspack-v2.pages.dev

View logs

@hardfist
hardfist merged commit 58833aa into main Mar 31, 2026
36 checks passed
@hardfist
hardfist deleted the chore/crate_oicd_pub branch March 31, 2026 06:22
stormslowly added a commit that referenced this pull request Mar 31, 2026
@stormslowly
chore(backport): use OIDC to publish crates (#13543)
f7ed3b8
@stormslowly stormslowly mentioned this pull request Mar 31, 2026
Merged
hardfist pushed a commit that referenced this pull request Apr 1, 2026
@stormslowly
chore(backport): use OIDC to publish crates (#13563)
c7d5345 
chore(backport): use OIDC to publish crates (#13543)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@hardfist hardfist hardfist approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stormslowly @hardfist