Skip to content

Fix test failures on main#2005

Merged
dirkkul merged 8 commits intomainfrom
fix_async_test
Apr 9, 2026
Merged

Fix test failures on main#2005
dirkkul merged 8 commits intomainfrom
fix_async_test

Conversation

@dirkkul
Copy link
Copy Markdown
Collaborator

@dirkkul dirkkul commented Apr 8, 2026 •
edited
Loading

  • Skip async replication test for old version
  • Fix async replicaiton worker tests
  • delete flaky lazy shard loading test (already deleted in dev/v1.37)
  • update to latest versions

Copilot AI review requested due to automatic review settings April 8, 2026 17:34
orca-security-eu[bot]
orca-security-eu bot reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copilot AI reviewed Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates an integration test to be version-aware by skipping async replication configuration validation on Weaviate versions that don’t support it.

Changes:

  • Add a Weaviate version gate to test_replication_config_with_async_config to skip on versions < 1.34.18.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.92%. Comparing base (ccf4f61) to head (8de3b89).
⚠️ Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
integration/test_collection_config.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2005      +/-   ##
==========================================
+ Coverage   87.84%   87.92%   +0.08%     
==========================================
  Files         280      280              
  Lines       21347    21639     +292     
==========================================
+ Hits        18752    19027     +275     
- Misses       2595     2612      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul dirkkul requested a review from a team as a code owner April 8, 2026 17:53
@dirkkul dirkkul changed the title Skip async replication test for old version Fix test failures on main Apr 8, 2026
@dirkkul dirkkul merged commit c6135f5 into main Apr 9, 2026
123 of 124 checks passed
@dirkkul dirkkul deleted the fix_async_test branch April 9, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirkkul @codecov-commenter