feat(config): add baseURL parameter to Cohere reranker#558
Open
feat(config): add baseURL parameter to Cohere reranker#558
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
antas-marcin
reviewed
Apr 8, 2026
| @@ -1362,10 +1362,12 @@ public static Object[][] testCases() { | |||
| { | |||
| Reranker.class, | |||
| Reranker.cohere(rerank -> rerank | |||
Collaborator
There was a problem hiding this comment.
can you add a test without the baseURL?
Collaborator
Author
There was a problem hiding this comment.
I can add that test case, but IMO it does not add any value.
CohereReranker is a plain Java record and handling "baseURL is null" is something Gson does, not us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #522