Skip to content

add Cmd+, shortcut to open Settings, Esc to close#3308

Open
mrdiin wants to merge 1 commit into
wavetermdev:mainfrom
mrdiin:feat/cmd-comma-settings
Open

add Cmd+, shortcut to open Settings, Esc to close#3308
mrdiin wants to merge 1 commit into
wavetermdev:mainfrom
mrdiin:feat/cmd-comma-settings

Conversation

@mrdiin
Copy link
Copy Markdown

@mrdiin mrdiin commented May 12, 2026

Adds a Cmd+, keyboard shortcut to open the Settings panel as an ephemeral block (matching the gear icon behavior). Pressing Escape while focused on Settings or Tips closes the block.

Changes

  • frontend/app/store/keymodel.ts: Register Cmd+, global shortcut that calls createBlock with ephemeral flag; extend Escape handler to close waveconfig and tips blocks when focused
  • frontend/app/element/quicktips.tsx: Add "Open Settings" (Cmd+,) and "Close Settings / Close Search" (Escape) entries to the Tips block's Main Keybindings section
  • docs/docs/keybindings.mdx: Document Cmd+, in the Global Keybindings table

Testing

Open Tips block to see the new shortcuts listed. Press Cmd+, to open Settings, press Escape to close it.

@mrdiin mrdiin changed the title add Cmd-, shortcut to open Settings, Esc to close add Cmd+, shortcut to open Settings, Esc to close May 12, 2026
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 12, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 12, 2026 •
edited
Loading

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c63be0a0-a52f-4d6d-9068-14988a12eb7f

📥 Commits

Reviewing files that changed from the base of the PR and between 021db67 and 6e27bbb.

📒 Files selected for processing (3)
  • docs/docs/keybindings.mdx
  • frontend/app/element/quicktips.tsx
  • frontend/app/store/keymodel.ts

Walkthrough

This PR adds a new Settings keybinding feature for macOS. The implementation adds a global Cmd:, shortcut in keymodel.ts that creates a waveconfig block for the Settings view. The Escape key handler is extended to detect when a waveconfig or tips view is focused and closes it via layoutModel.closeFocusedNode(). The new keybindings are documented in the quicktips UI component and the keybindings reference documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: adding a Cmd+, shortcut to open Settings and Escape to close it, which directly matches the primary objective of the pull request.
Description check ✅ Passed The description is well-related to the changeset, clearly outlining the three files modified and explaining the keyboard shortcut functionality being added, with testing instructions included.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrdiin @CLAassistant